Allow and test wrapt 2.x#88
Merged
laurent-laporte-pro merged 5 commits intolaurent-laporte-pro:developfrom Oct 29, 2025
Merged
Conversation
JarheadStever
left a comment
There was a problem hiding this comment.
@musicinmybrain hoping to revisit this now that it appears wrapt 2.0.0 was released on October 19th. I went to make a PR and saw yours was here already. @laurent-laporte-pro are you the primary reviewer/maintainer for this repo?
4588d59 to
21cd22a
Compare
Contributor
Author
|
I finally got back to this, both here and downstream in Fedora. I’m about to adjust diff --git a/tox.ini b/tox.ini
index 0d59799..8959450 100644
--- a/tox.ini
+++ b/tox.ini
@@ -25,7 +25,7 @@ deps =
wrapt1.12: wrapt ~= 1.12.0
wrapt1.13: wrapt ~= 1.13.0
wrapt1.14: wrapt ~= 1.14.0
- wrapt2.0: wrapt ~= 2.0.0rc1
+ wrapt2.0: wrapt ~= 2.0.0
coverage
setuptools; python_version>="3.12"
|
adfeaba to
596bf9c
Compare
e434951 to
21cd22a
Compare
8e05873
into
laurent-laporte-pro:develop
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this patch does to fix the issue.
This simply loosens the version bound on the
wraptdependency to allow versions 2.x, then starts testing them usingwrapt2.0.0rc1, https://github.com/GrahamDumpleton/wrapt/blob/2.0.0rc1/docs/changes.rst. I maintain thepython-wraptpackage in Fedora, and this PR is part of my work to make sure that I am ready to shipwrapt2.0.0 in Rawhide, the development version of Fedora, as soon as 2.0.0 final is released.I do not know if testing
wrapt2.x on Python 3.7 will work; Python 3.7 has been end-of-life long enough that I cannot easily install an interpreter to test locally.Link to any relevant issues or pull requests.
Ideally, #71 would be completed and merged to drop Python 3.7 support, and a similar change would drop Python 3.8 support since it has also reached end of life.
Similarly, it would be good to test with and declare support for #85, and since Python 3.14 is in the release candidate phase, it’s not too early to add support for it, as well.