Add default converter for timestamp with timezone#554
Merged
laughingman7743 merged 4 commits intopyathena-dev:masterfrom Aug 6, 2024
gontzalm:master
Merged
Add default converter for timestamp with timezone#554laughingman7743 merged 4 commits intopyathena-dev:masterfrom gontzalm:master
laughingman7743 merged 4 commits intopyathena-dev:masterfrom
gontzalm:master
Conversation
Member
|
https://github.com/laughingman7743/PyAthena/blob/master/tests/pyathena/test_cursor.py#L410-L506 |
Member
|
Add python-dateutil as a dependency. [project]
name = "PyAthena"
description = "Python DB API 2.0 (PEP 249) client for Amazon Athena"
authors = [
{name = "laughingman7743", email = "laughingman7743@gmail.com"},
]
dependencies = [
"boto3>=1.26.4",
"botocore>=1.29.4",
"tenacity>=4.1.0",
"fsspec",
+ "python-dateutil"
]Add types-python-date to the development environment dependencies. [tool.hatch.envs.default]
python = "3.11"
type = "pip-compile"
lock-filename = "requirements/requirements.txt"
pip-compile-verbose = true
pip-compile-hashes = true
pip-compile-install-args = [
"--no-deps"
]
dependencies = [
"wheel",
"twine",
"sqlalchemy>=1.0.0",
"pandas>=1.3.0",
"numpy>=1.26.0;python_version>=\"3.9\"",
"numpy>=1.24.0,<1.26.0;python_version<\"3.9\"",
"pyarrow>=7.0.0",
"fastparquet>=0.4.0",
"Jinja2>=3.1.0",
"mypy>=0.900",
"pytest>=3.5",
"pytest-cov",
"pytest-xdist",
"pytest-dependency",
"ruff>=0.1.13",
"hatch-pip-compile",
"sphinx",
+ "types-python-dateutil"
]The following command will update the files under the requirements directory. Commit the changes. |
Member
|
I think the change looks good. Please update the code format and dependencies. |
added 2 commits
August 6, 2024 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the
timestamp with time zone->_to_datetime_with_tzkey value pair to the
_DEFAULT_CONVERTERSdictionary.Context
When using the feature #360 from the dbt-athena connector with partitioned columns of
timestamp with time zonetype, I am getting the errorThis is because
pyathenadoes not convert thetimestamp with time zonetype (it leaves it asstr) anddbt-athenacompiles the SQLwhereclause asWith this PR, the
dbt-athenaconnector works as expected: