Add support for the Sass Deprecations API (fixes #671)#673
Merged
larsgrefer merged 1 commit intolarsgrefer:4.xfrom Jun 7, 2025
Merged
Add support for the Sass Deprecations API (fixes #671)#673larsgrefer merged 1 commit intolarsgrefer:4.xfrom
larsgrefer merged 1 commit intolarsgrefer:4.xfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #673 +/- ##
======================================
Coverage ? 64.81%
Complexity ? 314
======================================
Files ? 51
Lines ? 1421
Branches ? 208
======================================
Hits ? 921
Misses ? 355
Partials ? 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Sass Deprecation API.
It's inherently difficult to add test cases for this API as the test cases might break as soon as the deprecated feature gets removed.
Even though, I've added test cases for
fatalDeprecationsandsilenceDeprecationsbased on the deprecationglobal-builtin, scheduled to be removed in dart-sass 3.0. As of now, there are nofutureDeprecationsso testing those seems impossible.