Merged
Conversation
jkmartindale
requested changes
Feb 26, 2021
Collaborator
jkmartindale
left a comment
There was a problem hiding this comment.
Just wanna see the track labels fixed like with playlists
Since you branched off feature/playlist instead of staging (totally understand how easy it is to accidentally branch off another feature branch), we'll need to wait until #30 gets merged in, and then very carefully resolve merge conflicts coming from this branch's copy of the work in feature/playlist. Should probably be merged in with Squash and Merge.
End of file line break added Co-authored-by: James Martindale <11380394+jkmartindale@users.noreply.github.com>
Lovely Nullish Coalescing Operator added Co-authored-by: James Martindale <11380394+jkmartindale@users.noreply.github.com>
this.description updated in AlbumsAndTracks constructor Co-authored-by: James Martindale <11380394+jkmartindale@users.noreply.github.com>
Cleaned up comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully functioning albums sidebar with tracks that play/add-to-queue