Skip to content

[9.x] Add analytics for meilisearch engine#681

Merged
taylorotwell merged 2 commits intolaravel:9.xfrom
mmachatschek:meilisearch_analytics
Dec 27, 2022
Merged

[9.x] Add analytics for meilisearch engine#681
taylorotwell merged 2 commits intolaravel:9.xfrom
mmachatschek:meilisearch_analytics

Conversation

@mmachatschek
Copy link
Copy Markdown
Contributor

This adds user agent information to the meilisearch client to support anonymous telemetry on Meilisearch side

#678 (comment)

Copy link
Copy Markdown
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmachatschek!

Comment thread src/ScoutServiceProvider.php Outdated
@driesvints
Copy link
Copy Markdown
Member

@mmachatschek I merged this PR into 10.x, can you update your PR?

@mmachatschek mmachatschek deleted the meilisearch_analytics branch January 5, 2023 08:09
@d8vjork
Copy link
Copy Markdown

d8vjork commented Jan 5, 2023

Somehow ScoutServiceProvider is now failing on my company's CI when installing composer packages (at dumpautoload):

image

image

We can't ignore autoload, so we downgrade Scout version to one before this PR anyway I think this must be fixed

@d8vjork
Copy link
Copy Markdown

d8vjork commented Jan 5, 2023

Ok, issue found with latest composer release: 2.5.1

Solved by downgrading to 2.4.x, seems related to Composer

@driesvints
Copy link
Copy Markdown
Member

Please see #687 as this is a change in meilisearch php

@d8vjork
Copy link
Copy Markdown

d8vjork commented Jan 5, 2023

Please see #687 as this is a change in meilisearch php

I see, seems thought downgrading Scout solved it from now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants