[10.x] Dispatch failed notification event#52356
Closed
dam1r89 wants to merge 4 commits intolaravel:10.xfrom
Closed
[10.x] Dispatch failed notification event#52356dam1r89 wants to merge 4 commits intolaravel:10.xfrom
dam1r89 wants to merge 4 commits intolaravel:10.xfrom
Conversation
Author
|
Actually, this could be a problem, misconfigured mail would silently fail, so maybe rethrow the error after the event has been dispatched? |
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event
NotificationFailedexisted but was never used.There is a small difference in how the code will behave with this error caching. For example, before if the first channel failed, the rest of them would fail too, now others will be processed.