[8.x] Add File::lines($path) method#34187
Merged
taylorotwell merged 1 commit intolaravel:8.xfrom Sep 8, 2020
Merged
Conversation
mstaack
reviewed
Sep 7, 2020
37da74d to
d7b139c
Compare
d7b139c to
154fef3
Compare
richardkeep
approved these changes
Sep 7, 2020
Collaborator
|
Lazy collections could be quite appropriate for paginating eloquent queries tbh. Currently there's an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the most useful scenarios for using lazy collections involves reading files line by line (see here for more details).
This PR adds a
linesmethod to theFilesystemclass, to lazily read the lines of a file:Example
With this in place, you can easily read Laravel's logs lazily (using the new
chunkWhilemethod):The
$logsvariable will now be a lazy collection, from which we can pull out a single log entry at a time.