[6.0] Remove mutating methods from lazy collection#29671
Merged
taylorotwell merged 2 commits intolaravel:6.0from Aug 21, 2019
Merged
[6.0] Remove mutating methods from lazy collection#29671taylorotwell merged 2 commits intolaravel:6.0from
taylorotwell merged 2 commits intolaravel:6.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removed methods are:
add($item)forget($keys)pop()prepend($value, $key = null)push($value)put($key, $value)shift()splice($offset, $length = null, $replacement = [])transform(callable $callback)I originally added them for feature-parity with the regular collection class, but after giving it some more thought I realized that it doesn't really make sense.
It's very easy to accidentally enumerate values twice, or accidentally enumerate the whole collection.
After removing mutation, I was able to simplify the code quite a bit.
Alternative
Some of these methods could theoretically be implemented without mutation, by just returning a new collection.
However, I believe that would lead to a lot of confusion, since the regular collection class does get mutated with these methods.