[3.x] fix: allow private methods to be used as accessors#2334
Closed
calebdw wants to merge 1 commit intolarastan:3.xfrom
Closed
[3.x] fix: allow private methods to be used as accessors#2334calebdw wants to merge 1 commit intolarastan:3.xfrom
calebdw wants to merge 1 commit intolarastan:3.xfrom
Conversation
Rector automatically converts protected methods to private in final classes (as it should). However, this breaks attribute detection.
Contributor
Author
|
Actually, it looks like model attributes (and scopes) have to be protected and cannot be private---otherwise the parent Model is not able to call the methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Rector automatically converts protected methods to private in final classes (as it should). However, this breaks attribute detection.
Thanks!