Skip to content

Add external indexing tcp server#142

Merged
var77 merged 9 commits intomainfrom
varik/external-indexing-server
Jul 25, 2024
Merged

Add external indexing tcp server#142
var77 merged 9 commits intomainfrom
varik/external-indexing-server

Conversation

@var77
Copy link
Copy Markdown
Collaborator

@var77 var77 commented Jul 16, 2024 •
edited
Loading

Add external indexing tcp server, which will accept streamed tuples from C, create usearch index and send index back via socket

TODO

  • Handle scalar quantization
  • Add tests
  • Decide on allowing more than 1 connection at a time

@var77
add external indexing tcp server, which will accept streamed tuples f…
d63c93c 
…rom C, create usearch index and send index back via socket
@var77 var77 mentioned this pull request Jul 16, 2024
Merged
1 task
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 17, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.67606% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.99%. Comparing base (7f5463a) to head (5bfa910).
⚠️ Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
lantern_cli/src/external_index/server.rs 95.57% 15 Missing ⚠️
lantern_cli/src/external_index/cli.rs 45.45% 6 Missing ⚠️
lantern_cli/src/main.rs 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   63.79%   64.99%   +1.19%     
==========================================
  Files          45       46       +1     
  Lines        8309     8664     +355     
==========================================
+ Hits         5301     5631     +330     
- Misses       3008     3033      +25
Files with missing lines Coverage Δ
lantern_cli/src/external_index/mod.rs 90.75% <ø> (ø)
lantern_cli/src/main.rs 0.00% <0.00%> (ø)
lantern_cli/src/external_index/cli.rs 48.80% <45.45%> (+0.86%) ⬆️
lantern_cli/src/external_index/server.rs 95.57% <95.57%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@var77 var77 force-pushed the varik/external-indexing-server branch from 86bda96 to 061761c Compare July 17, 2024 11:34
@var77 var77 marked this pull request as ready for review July 17, 2024 11:34
@var77 var77 requested a review from Ngalstyan4 July 17, 2024 14:52
@var77 var77 mentioned this pull request Jul 18, 2024
Closed
Ngalstyan4
Ngalstyan4 approved these changes Jul 22, 2024
View reviewed changes
lantern_cli/src/external_index/server.rs Outdated
use crate::logger::{LogLevel, Logger};
use crate::types::*;

const LABEL_SIZE: usize = 8; // for now we are only using 32bit integers
Copy link
Copy Markdown
Contributor

@Ngalstyan4 Ngalstyan4 Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the comment right? labels are always 64 bit right?

@var77 var77 force-pushed the varik/external-indexing-server branch from ec959fe to 5bfa910 Compare July 23, 2024 12:25
@var77 var77 requested a review from Ngalstyan4 July 23, 2024 15:09
@var77 var77 merged commit f64df19 into main Jul 25, 2024
@var77 var77 deleted the varik/external-indexing-server branch July 25, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ngalstyan4 Ngalstyan4 Awaiting requested review from Ngalstyan4

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@var77 @codecov-commenter @Ngalstyan4