Skip to content

Narek/update deps#347

Merged
var77 merged 10 commits intomainfrom
narek/update_deps
Oct 29, 2024
Merged

Narek/update deps#347
var77 merged 10 commits intomainfrom
narek/update_deps

Conversation

@Ngalstyan4
Copy link
Copy Markdown
Contributor

@Ngalstyan4 Ngalstyan4 commented Oct 29, 2024

This updates (almost) all rust dependencies of the project

Dependencies left out of date:

  1. gcp_auth - An authentication API changed, did not upgrade since I did not know the new API and the right way to test
  2. ndarray - upgrading causes some cryptic error messages

Notes on pgrx upgrade:

  • The added [[bin]] section and the pgrx_embed.rs file were required by pgrx 0.12.*. Those would be autogenerated if we created a pgrx project with the new version.
  • I dropped pg11 but have not added pg17 yet. Let's do that separately. I just needed pgrx 0.12.* for other changes.

@Ngalstyan4 Ngalstyan4 requested a review from var77 October 29, 2024 01:56
greptile-apps[bot]
greptile-apps bot reviewed Oct 29, 2024
View reviewed changes
Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 29, 2024 •
edited
Loading

Benchmarks

metric old new pct change
recall (after create) 0.951 0.951 -
recall (after insert) 0.000 0.000 -
select tps 24461.092 27220.143 +11.28%
select bulk(100) tps 34.979 35.354 +1.07%
select latency (ms) 0.715 ± 1.680𝜎 0.758 ± 1.745𝜎 +6.01%
select bulk(100) latency (ms) 882.925 ± 148.875𝜎 868.241 ± 135.777𝜎 -1.66%
create latency (ms) 396115.659 396837.678 +0.18%
insert tps 428.750 436.823 +1.88%
insert bulk(100) tps 4.621 4.545 -1.65%
insert latency (ms) 74.060 ± 15.745𝜎 72.618 ± 15.629𝜎 -1.95%
insert bulk(100) latency (ms) 6784.263 ± 186.056𝜎 6833.156 ± 177.592𝜎 +0.72%
disk usage (bytes) 8192008192.000 8192008192.000 -

var77
var77 reviewed Oct 29, 2024
View reviewed changes
@var77 var77 merged commit 7b0b553 into main Oct 29, 2024
@var77 var77 deleted the narek/update_deps branch October 29, 2024 08:16
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lantern_cli/src/embeddings/core/openai_runtime.rs 0.00% 3 Missing ⚠️
lantern_cli/src/pq/gcp_batch.rs 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@var77 var77 var77 left review comments

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ngalstyan4 @var77