Conversation
There was a problem hiding this comment.
PR Summary
This pull request implements significant changes to the external indexing system in Lantern, focusing on improved communication protocols and error handling for index data retrieval.
- Introduced protocol version checking and server type verification in
src/hnsw/external_index_socket.cto ensure compatibility and proper routing - Renamed
external_index_receive_index_parttoexternal_index_receive_allacross multiple files, suggesting a shift to more efficient bulk data retrieval - Added
wait_for_datafunction insrc/hnsw/external_index_socket.cfor asynchronous data availability checks, improving interrupt handling - Implemented error message retrieval from external indexing server after receiving error magic bytes in
src/hnsw/external_index_socket.c - Updated
src/hnsw/external_index_socket.hwith new constants for protocol version and router server type, supporting the enhanced communication system
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Base automatically changed from
varik/external-index-streaming-write
to
main
September 16, 2024 16:05
…col version on first message, handle error messages correctly
9869e97 to
1dfe10f
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Benchmarks
|
…RY to cleanup build index resources after errors and interrupts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
external_index_receive_index_parttoexternal_index_receive_allwait_for_datawhich will asynchronously check for data to be available for reading on socket. This will let us to handle interrupts while waiting for data