Skip to content

Narek/hnswbuild single wal pass#319

Merged
Ngalstyan4 merged 28 commits intomainfrom
narek/hnswbuild-single-wal-pass
Jun 12, 2024
Merged

Narek/hnswbuild single wal pass#319
Ngalstyan4 merged 28 commits intomainfrom
narek/hnswbuild-single-wal-pass

Conversation

@Ngalstyan4
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

7 similar comments
@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@codecov
Copy link
Copy Markdown

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/hnsw/external_index.c 53.84% 0 Missing and 6 partials ⚠️

📢 Thoughts on this report? Let us know!

@Ngalstyan4 Ngalstyan4 force-pushed the narek/hnswbuild-single-wal-pass branch from f684ed7 to 552cdb2 Compare May 15, 2024 03:59
@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

9 similar comments
@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@Ngalstyan4 Ngalstyan4 force-pushed the narek/hnswbuild-single-wal-pass branch from da205dc to 7833941 Compare May 20, 2024 02:21
@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

8 similar comments
@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

@github-actions
Copy link
Copy Markdown

The update tests on Linux failed. Please check the logs for more details.

Round hnsw_sq distances to avoid regression errors

Update tests after switching overlooked sequential searches to index searches

Fix tests to avoid sequential scans and switch to index scans

Disable costs in some quantized vector query explains
Use qant_bits option variable in index builds
We previously fiterled this out in newer PGs only if tests were run with
a filter. This makes sure filtering always happens
@Ngalstyan4 Ngalstyan4 force-pushed the narek/hnswbuild-single-wal-pass branch 5 times, most recently from 561e475 to 683be80 Compare June 12, 2024 06:30
Round hnsw_sq test result distances to avoid regressions
We used to use log_newpage_buffer API for this which required explicit
critical section marks in extension code. To be consistent with index
build procedure on logged tables, we switched this to log_newpage_range
Rename and improve integration tests. Also add pry()!!

Add replication and insert tests

Simplify integration test fixtures

Add unlogged table crash tests

cleanup fixture definition in integration tests

Clean up low recall warnings

aslkdj
bring back pg user for test yaml integration

Fix pytest permission issue

Switch to using HEAD of testgres

Explisitly pass rootdir in test.yaml so integration test script does not look for it

run pytset via python3 -m
@Ngalstyan4 Ngalstyan4 force-pushed the narek/hnswbuild-single-wal-pass branch from 683be80 to 9d9f391 Compare June 12, 2024 06:40
@Ngalstyan4 Ngalstyan4 force-pushed the narek/hnswbuild-single-wal-pass branch from 9d9f391 to f95c933 Compare June 12, 2024 06:43
@Ngalstyan4 Ngalstyan4 force-pushed the narek/hnswbuild-single-wal-pass branch from f95c933 to 7bb2687 Compare June 12, 2024 06:52
@Ngalstyan4 Ngalstyan4 merged commit d12390e into main Jun 12, 2024
@Ngalstyan4 Ngalstyan4 deleted the narek/hnswbuild-single-wal-pass branch June 12, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants