Add NDEBUG during code coverage to disable asserts

Ngalstyan4 · Ngalstyan4 · commit 26e62c5ecf87 · 2023-08-07T07:47:20.000Z
The macro 'assert' is implemented as a conditional which
causes codecov think the line is always partially covered
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -30,6 +30,10 @@ if(CODECOVERAGE)
   # for the given compiler.  For example, with GCC, --coverage translates to
   # -fprofile-arcs -ftest-coverage when compiling and -lgcov when linking
   add_compile_options(--coverage -O0)
+  # add NDEBUG to make sure asserts compile to a NOOP and do not negatively impact
+  # code coverage. Asserts check invariants but since 'assert' is defined as a macro-condition,
+  # codecov always considers it partially covered.
+  add_compile_definitions(NDEBUG)
   add_link_options(--coverage)
 endif(CODECOVERAGE)
 
