Skip to content

unify plugin base api parms for data structure, #19353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhanluxianshen wants to merge 1 commit into from
Closed

unify plugin base api parms for data structure, #19353

zhanluxianshen wants to merge 1 commit into from

Conversation

@zhanluxianshen
Copy link
Contributor

@zhanluxianshen zhanluxianshen commented May 7, 2025

No description provided.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 7, 2025
@zhanluxianshen
unify plugin base api parms for data structure,
84e9513 
Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
@zhanluxianshen zhanluxianshen force-pushed the unify-base-flugin-params-for-data branch from c8affb8 to 84e9513 Compare May 7, 2025 22:36
@crazywoola
Copy link
Member

crazywoola commented May 8, 2025

Please link an existing issue to describe why you want to change this.

@zhanluxianshen
Copy link
Contributor Author

zhanluxianshen commented May 8, 2025

Please link an existing issue to describe why you want to change this.

Although _request_with_model has no reference called.
But it is the same with _request_with_plugin_daemon_response and _stream_request, both method call _request(). But the method's parms define is not the same.

@zhanluxianshen zhanluxianshen deleted the unify-base-flugin-params-for-data branch August 8, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhanluxianshen @crazywoola