fix: delegate CompositeBackend.id to default sandbox backend#286
Merged
Christian Bromann (christian-bromann) merged 2 commits intolangchain-ai:mainfrom Mar 9, 2026
Conversation
🦋 Changeset detectedLatest commit: ab4dfc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CompositeBackend failed isSandboxBackend check because it lacked the
required id property from SandboxBackendProtocol. Added a get id()
getter that delegates to the default backend's id when it is a sandbox,
or returns an empty string otherwise. This preserves the real sandbox
ID (e.g. from Daytona/Deno/Modal) for external lifecycle operations
like provider.delete({ sandboxId: sandbox.id }).
Fixes langchain-ai#275
31b48f7 to
8ee1a06
Compare
Christian Bromann (christian-bromann)
approved these changes
Mar 9, 2026
Member
Christian Bromann (christian-bromann)
left a comment
There was a problem hiding this comment.
LGTM 👍
5f499ed
into
langchain-ai:main
11 checks passed
Member
|
Thank you! |
This was referenced Mar 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #275
CompositeBackendfailedisSandboxBackendcheck because it lacked theidproperty required bySandboxBackendProtocolget id()getter that delegates to the default backend'sidwhen it is a sandbox, or returns an empty string otherwiseRoot cause
isSandboxBackendchecks bothexecute(function) andid(string).CompositeBackendimplementedexecutebut had noidproperty, causing the check to returnfalseeven when the default backend supports execution.Why not just remove the
idcheck?Removing the
idcheck fromisSandboxBackendwould create an inconsistency between the interface and the type guard — external users who rely onSandboxBackendProtocol.idafter a successfulisSandboxBackendcheck could receiveundefinedat runtime. Since this is a public API, delegatingidto the underlying sandbox backend is the safer approach.Test plan
CompositeBackendpassesisSandboxBackendwhen default backend is a sandboxcomposite.idreturns the default sandbox backend's idcomposite.idreturns empty string when default backend is not a sandbox