Skip to content

fix: add serde feature flag dependency #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timsaucer wants to merge 3 commits into from
Closed

fix: add serde feature flag dependency #4833

timsaucer wants to merge 3 commits into from

Conversation

@timsaucer
Copy link
Contributor

@timsaucer timsaucer commented Sep 28, 2025

If you attempt to build with no default features for the lance crate (not just the workspace):

cargo build -p lance --no-default-features

Then you will get the following error:

error[E0277]: the trait bound `chrono::DateTime<chrono::Utc>: Deserialize<'_>` is not satisfied
   --> rust/lance/src/dataset.rs:175:10
    |
175 | #[derive(Deserialize, Serialize)]
    |          ^^^^^^^^^^^ the trait `Deserialize<'_>` is not implemented for `chrono::DateTime<chrono::Utc>`
    |
    = note: for local types consider adding `#[derive(serde::Deserialize)]` to your `chrono::DateTime<chrono::Utc>` type
    = note: for types from other crates check whether the crate offers a `serde` feature flag

This is a problem for projects that are using the lance crate and building with the --no-default-features flag. It can be overcome on the user's end by making this an explicit dependency during our builds, but it should probably be included here.

@timsaucer timsaucer changed the title fix: add serde feature flag depedency fix: add serde feature flag dependency Sep 28, 2025
@github-actions github-actions bot added the bug Something isn't working label Sep 28, 2025
@timsaucer timsaucer mentioned this pull request Sep 28, 2025
Open
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.85%. Comparing base (30dcb5b) to head (b2cdd1b).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4833   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files         329      329           
  Lines      129625   129625           
  Branches   129625   129625           
=======================================
+ Hits       104810   104814    +4     
+ Misses      21133    21129    -4     
  Partials     3682     3682
Flag Coverage Δ
unittests 80.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timsaucer timsaucer mentioned this pull request Sep 29, 2025
Open
@eddyxu
Copy link
Member

eddyxu commented Sep 29, 2025

Generally looks good. Pending CI

@wjones127
Copy link
Contributor

wjones127 commented Dec 19, 2025

Fixed in #5110

@wjones127 wjones127 closed this Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timsaucer @codecov-commenter @eddyxu @wjones127