ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.83%. Comparing base (4780af9) to head (4c4a613).

@@            Coverage Diff             @@
##             main    #4825      +/-   ##
==========================================
- Coverage   80.83%   80.83%   -0.01%     
==========================================
  Files         329      329              
  Lines      129559   129562       +3     
  Branches   129559   129562       +3     
==========================================
- Hits       104730   104728       -2     
- Misses      21148    21150       +2     
- Partials     3681     3684       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

More generally I wonder if we should be doing this sql parsing at all when we know we have columns. Should ProjectionPlan::from_expressions actually take in instead columns: &[(impl AsRef<str>, &Expr)] ?

Could you expand more on what you mean by that?

I think the intention of the expression was to allow indexing nested fields or fields within JSON blobs.

This PR avoids a problem encountered when creating a scalar index on a column that had a name that was not easily parseable by the SQL parser.

Actually, before I merge, do you think this is worth a unit test?