Refactor python source command and error reporting#3521
Merged
akohlmey merged 8 commits intoNov 15, 2022
Conversation
sjplimp
reviewed
Nov 11, 2022
sjplimp
reviewed
Nov 11, 2022
sjplimp
reviewed
Nov 14, 2022
sjplimp
requested changes
Nov 14, 2022
sjplimp
left a comment
Contributor
There was a problem hiding this comment.
thanks for the changes, added a few grammatical changes, that should be it
sjplimp
reviewed
Nov 14, 2022
sjplimp
reviewed
Nov 14, 2022
sjplimp
reviewed
Nov 14, 2022
sjplimp
requested changes
Nov 14, 2022
sjplimp
left a comment
Contributor
There was a problem hiding this comment.
see 3 comments - must not have stored them correctly before as you didn't respond on the last iteration ...
sjplimp
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the processing of the
python sourcecommand to be more obvious and avoid using dummy function names.Also, the error reporting is improved and the documentation more detailed about limitations when the python interpreter is linked to the Python runtime statically when calling back to LAMMPS via the LAMMPS python module.
Related Issue(s)
closes #3520
Author(s)
Axel Kohlmeyer, Temple U
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
The syntax of the
python sourcecommand is changed.Post Submission Checklist