Fix return-type for Sendmail::prepareSubject and the Sendmail::prepareParameters#242
Merged
Slamdunk merged 18 commits intolaminas:2.23.xfrom May 25, 2023
Merged
Conversation
…Parameters have been fixed
…mail has been added.
This reverts commit 7c2afd0.
This reverts commit f9f43a3.
This reverts commit f07d863.
…sending mail has been added." This reverts commit fab234c.
…ng' for Laminas\Mail\Transport\Envelope::getFrom is not nullable, but 'null|string' contains null (see https://psalm.dev/144)" has been fixed
Contributor
Author
|
@Ocramius |
Slamdunk
requested changes
May 25, 2023
| <file src="src/Transport/Envelope.php"> | ||
| <InvalidNullableReturnType> | ||
| <code>string</code> | ||
| </InvalidNullableReturnType> |
Contributor
There was a problem hiding this comment.
I see you've removed the InvalidNullableReturnType from src/Transport/Envelope.php, but I rather not touch the Envelope class properties as it could be seen as a BC Break.
In #241 (comment) the only InvalidNullableReturnType removal I suggest is the src/Transport/Sendmail.php, which in this PR is still in place
This reverts commit 2274fbc52236c46266934e2bfa9cc1cee801b8e8.
This reverts commit 6514c48c1bada0d5cdb2ddad0a66f7d509506a50.
…pe 'string' for Laminas\Mail\Transport\Envelope::getFrom is not nullable, but 'null|string' contains null (see https://psalm.dev/144)" has been fixed" This reverts commit d5038a6d544e27929a7da242758ee76be80da089.
….php instead of src/Transport/Envelope.php Signed-off-by: Artemii Karkusha <artemii.karkusha@gmail.com>
Signed-off-by: Artemii Karkusha <artemii.karkusha@gmail.com>
Slamdunk
approved these changes
May 25, 2023
Contributor
|
Thank you |
Sendmail::prepareSubject and the Sendmail::prepareParameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of returning for functions of the prepareSubject and the prepareParameters have been fixed
#240