Well, I corrected all the checks I understood but the 2 failing are very unclear to me. The two failing tests state:

Running ./vendor/bin/phpunit
PHP Fatal error:  Cannot make static method Laminas\ServiceManager\Test\CommonPluginManagerTrait::getPluginManager() non static in class LaminasTest\Mail\Protocol\SmtpPluginManagerCompatibilityTest in /github/workspace/test/Protocol/SmtpPluginManagerCompatibilityTest.php on line 16

Fatal error: Cannot make static method Laminas\ServiceManager\Test\CommonPluginManagerTrait::getPluginManager() non static in class LaminasTest\Mail\Protocol\SmtpPluginManagerCompatibilityTest in /github/workspace/test/Protocol/SmtpPluginManagerCompatibilityTest.php on line 16

but neither is Laminas\ServiceManager\Test\CommonPluginManagerTrait::getPluginManager() static:

    /**
     * Returns the plugin manager to test
     *
     * @return AbstractPluginManager
     */
    abstract protected function getPluginManager();

nor did I change anything in the LaminasTest\Mail\Protocol\SmtpPluginManagerCompatibilityTest class.

Quite confused, maybe a wrong test?

Best regards,
Willi

Failure seems indeed unrelated to your changes 🤔

This is a BC break in ServiceManager 3.21

Dropping support for PHP 8.0, bumping ServiceManager to ^3.21 and making the relevant method static here will 'fix' it, alternatively a conflict with 3.21 of SM ??

IMO just bumping in a new PR

Hi there, so I understand the problems. I was trying to solve it, but now I am giving up, see
other PR #238. I'll open an issue about the case, because the test configuration and how to deal with

This is a BC break in ServiceManager 3.21

are way over my knowledge concerning the project. I'll merge the corrected branch in mine, once the work is done and hopefully it will pass all tests then.

Best regards,

Willi

To be clear, not expecting you to fix it: the situation arises due to internal breakages.

Thanks for trying though!

@schnumsel I've fixed the upstream branch in #233

Can you rebase yours please?

@schnumsel you merged upstream via 87bf441

@Slamdunk needs a rebase here :D

@Slamdunk Thanks! @Ocramius not very familiar with these steps I should have done a force push, I'll try ...

So this one goes without rebase.... I'll learn :)

Thank you @schnumsel