Set limits to Generic.Files.LineLength phpcs rule#132
Closed
glensc wants to merge 1 commit intolaminas:2.14.xfrom
Closed
Set limits to Generic.Files.LineLength phpcs rule#132glensc wants to merge 1 commit intolaminas:2.14.xfrom
glensc wants to merge 1 commit intolaminas:2.14.xfrom
Conversation
Contributor
Author
and this is exactly how phpcs behaves: but the problem is that WARNING is treated as fatal, perhaps turn that off? I currently can't find how is that behaviour controlled. |
Member
|
This is the wrong direction because:
|
Contributor
Author
|
@froschdesign such request came from @Ocramius: perhaps you can jump in there and propose (show), how to set the exclude, as indicated there, previous attempts have failed (nothing works). the PR itself was extracted from larger PR as was unable to solve the cs exclude rule there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
lineLimitphpcs rule to be able to merge #126https://github.com/squizlabs/PHP_CodeSniffer/wiki/Customisable-Sniff-Properties#genericfileslinelength