This repository was archived by the owner on Jul 17, 2024. It is now read-only.
PHP 8.3 support added#31
Merged
weierophinney merged 5 commits intolaminas:3.11.xfrom Nov 6, 2023
Merged
Conversation
Contributor
Author
|
It seems some issue with infrastructure, The error is typically caused by one of the following reasons: An outdated or incompatible version of Node.js or OpenSSL is installed on your system. |
|
@Ocramius Is there any update on the infrastructure fixes on this PR. Can you please advise ? |
Member
|
@glo17680
Any help with this is welcome! |
48c88e2 to
7394eff
Compare
Blowfish is no longer supported by some versions of OpenSSL; this patch updates tests that validate factories and the `setAlgorithm()` method to use AES instead as it should be present regardless of version. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
This patch updates test cases to work with current OpenSSL versions, which have deprecated and/or removed some algorithms, as well as changed requirements for some. - Use AES instead of Blowfish for tests; guaranteed to be available on both old and new OpenSSL versions. - Use a MUCH larger prime number in Diffie-Hellman tests (number used is reported in current PHP manual examples) Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Member
|
I pulled your branch locally, and was able to resolve all test failures:
It looks like we get failures on PHP 8.0, however; I'll see if I can resolve those. |
Updates tests to skip certain algorithms that are unsupported in OpenSSL 3. Since you can compile PHP against earlier versions of OpenSSL, I took the decision to NOT mark them unsupported completely within the library code. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Member
|
Failures on PHP 8 were due to some algorithms being unsupported in OpenSSL 3; I've updated tests to skip those algorithms if that version of the library is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description