feat(L2): implement Into<RpcRequest> for EngineAPI request structs#606
Merged
ilitteri merged 2 commits intoOct 2, 2024
Merged
Conversation
ilitteri
reviewed
Oct 1, 2024
ilitteri
approved these changes
Oct 1, 2024
ilitteri
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just one comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This avoid us to repeat the JSON-RPC specification on every request we want to make with EngineAPI.
Description
The trait
Into<RpcRequest>was implemented for every used EngineAPI request structure (e.g.NewPayloadV3Request) so we can create an Engine request and then convert it to anRpcRequest.