fix(l1): use eth capability version when decoding messages + fix BlockRangeUpdate handling#4360
Merged
Conversation
6d9ea4f to
66f4cdc
Compare
Lines of code reportTotal lines added: Detailed view |
BlockRangeUpdate messageBlockRangeUpdate handling
mpaulucci
reviewed
Sep 10, 2025
| - uses: actions/checkout@v4 | ||
| - name: Setup Hive | ||
| # TODO: Change repo back to https://github.com/ethereum/hive when | ||
| # https://github.com/ethereum/hive/pull/1325 is merged |
Collaborator
There was a problem hiding this comment.
can you remove this comment?
Contributor
Author
There was a problem hiding this comment.
The whole comment or just the part mentioning the PR? As we are still using our forked hive
mpaulucci
reviewed
Sep 10, 2025
| *self | ||
| .eth_version | ||
| .read() | ||
| .map_err(|err| RLPxError::InternalError(err.to_string()))?, |
Collaborator
There was a problem hiding this comment.
if we fail to decode a message, it's not necesarily an internal error, right? It could be that they sent us random bytes?
Contributor
Author
There was a problem hiding this comment.
The mapping there is for when we fail to read from the RwLock that holds the eth_version, so it is indeed an internal error
gianbelinche
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Being able to support eth/69 messages
Description
BlockRangeUpdate(latest_hash != zero)BlockRangeUpdateis invalidBlockRangeUpdateCloses #2785