feat: migrate storage to trie#410
Merged
Merged
Conversation
mpaulucci
reviewed
Sep 18, 2024
| } | ||
| } | ||
|
|
||
| pub fn is_latest(&self, storage: &Store) -> Result<bool, StoreError> { |
Collaborator
There was a problem hiding this comment.
do we want to keep this for future use maybe?
Contributor
Author
There was a problem hiding this comment.
Clippy wanted it gone, but we can add #[allow(unused)] if we want to keep it
mpaulucci
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Move account storage storage tries
Description
TrieDBimplementation for dusport libmdbx tables (the idea here is to use the same table for multiple tries, so one of the keys will be used to indicate which trie nodes are being stored (in the case of storage trie this will be the account's address) and the other key will be the node hash)StoreStore::get_storage_atnow also receives a block_number so it can fetch historical dataCloses #349