feat: discovery protocol peers revalidation#402
Merged
Conversation
mpaulucci
reviewed
Sep 17, 2024
mpaulucci
reviewed
Sep 17, 2024
mpaulucci
approved these changes
Sep 17, 2024
mpaulucci
left a comment
Collaborator
There was a problem hiding this comment.
minor comments, great work 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pr implements peers revalidation loop.
Description
In the discovery protocol, every
10min(this could be any number actually), we need to ping back those peers whose last ping was 24hs ago to re-validate the endpoint proof, if they don't ping back, we replace them with one from the replacements list.Changes:
discover_peers_server(the one we already had) andpeers_revalidation.UdpSocketandKademliaTablewere modified to be thread/concurrent safe.peers_revalidationimplements a tokio interval that lasts10minand works in the following way:3, otherwise to step4.This implementation is supported by some custom unit tests and e2e tests.
Advances on issue #154.