Skip to content

fix: minor issues with net crate#300

Merged
mpaulucci merged 3 commits into
mainfrom
fix-net
Aug 23, 2024
Merged

fix: minor issues with net crate#300
mpaulucci merged 3 commits into
mainfrom
fix-net

Conversation

@fmoletta

@fmoletta fmoletta commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

Motivation

Being able to run ethereum_rust with kurtosis localness without disabling network-related code.
This PR fixes a couple panic sources when running with kurtosis:

  • panics with out of bounds when accessing kademlia tables
  • panics when sending messages to socket addresses built from ivp6 node ips

Unsolved issues that still cause panics:

  • Some neighbour messages incoming from kurtosis have udp port set to 0

Description

  • Uses saturating sub when calculating kademlia bucket numbers
  • Converts ivp6 node ips into ipv4 when building socket addresses from neighbors

Closes None

@fmoletta fmoletta marked this pull request as ready for review August 21, 2024 13:56
@fmoletta fmoletta requested a review from a team as a code owner August 21, 2024 13:56

@ElFantasma ElFantasma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mpaulucci mpaulucci added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 3a49ed7 Aug 23, 2024
@mpaulucci mpaulucci deleted the fix-net branch August 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants