Skip to content

fix(levm): trying out things with eip 7702#2898

Closed
JereSalo wants to merge 1 commit into
mainfrom
levm/fix_eip7702_tx
Closed

fix(levm): trying out things with eip 7702#2898
JereSalo wants to merge 1 commit into
mainfrom
levm/fix_eip7702_tx

Conversation

@JereSalo

@JereSalo JereSalo commented May 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

Description

If we touch an account and processing of the authorization tuple is not valid we have to "undo" that touch. Instead, we touch the account only if it's gone right.

Edit: I think I'm wrong :)

Closes #issue_number

@JereSalo JereSalo self-assigned this May 22, 2025
@JereSalo JereSalo added the levm Lambda EVM implementation label May 22, 2025
@github-actions

github-actions Bot commented May 22, 2025

Copy link
Copy Markdown

Lines of code report

Total lines added: 0
Total lines removed: 33
Total lines changed: 33

Detailed view 
+-------------------------------------------------+-------+------+
| File                                            | Lines | Diff |
+-------------------------------------------------+-------+------+
| ethrex/crates/blockchain/mempool.rs             | 572   | -11  |
+-------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/eth/transaction.rs | 596   | -8   |
+-------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/lib.rs             | 15    | -1   |
+-------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/rpc.rs             | 629   | -10  |
+-------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/utils.rs           | 408   | -2   |
+-------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/utils.rs              | 488   | -1   |
+-------------------------------------------------+-------+------+

@github-actions

github-actions Bot commented May 22, 2025

Copy link
Copy Markdown

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 240.2 ± 1.2 238.7 242.0 1.00
levm_Factorial 813.3 ± 4.4 807.1 819.1 3.39 ± 0.02

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.533 ± 0.088 1.429 1.666 1.00
levm_FactorialRecursive 13.158 ± 0.383 12.946 14.202 8.58 ± 0.55

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 220.8 ± 8.9 210.9 235.4 1.00
levm_Fibonacci 815.7 ± 7.6 806.7 828.3 3.69 ± 0.15

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.8 ± 0.1 8.8 9.0 1.00
levm_ManyHashes 17.1 ± 0.2 16.9 17.6 1.93 ± 0.03

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.312 ± 0.033 3.290 3.402 1.00
levm_BubbleSort 5.448 ± 0.061 5.401 5.576 1.64 ± 0.02

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 255.5 ± 1.3 254.1 258.7 1.00
levm_ERC20Transfer 492.2 ± 2.8 488.9 498.6 1.93 ± 0.01

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 146.5 ± 3.1 145.1 155.1 1.00
levm_ERC20Mint 316.7 ± 2.7 313.6 322.1 2.16 ± 0.05

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.077 ± 0.012 1.066 1.102 1.00
levm_ERC20Approval 1.861 ± 0.006 1.855 1.875 1.73 ± 0.02

Main Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 250.0 ± 27.6 238.8 327.9 1.00
levm_Factorial 824.0 ± 9.3 811.9 843.3 3.30 ± 0.37

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.545 ± 0.092 1.420 1.660 1.00
levm_FactorialRecursive 13.116 ± 0.166 12.924 13.321 8.49 ± 0.52

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 209.4 ± 0.7 208.6 211.0 1.00
levm_Fibonacci 818.0 ± 13.0 801.2 846.4 3.91 ± 0.06

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.7 ± 0.1 8.6 8.9 1.00
levm_ManyHashes 17.1 ± 0.1 16.9 17.3 1.97 ± 0.02

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.287 ± 0.026 3.254 3.334 1.00
levm_BubbleSort 5.474 ± 0.033 5.441 5.543 1.67 ± 0.02

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 252.2 ± 1.5 250.0 254.9 1.00
levm_ERC20Transfer 496.5 ± 4.3 491.8 505.1 1.97 ± 0.02

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 143.5 ± 0.8 142.8 145.5 1.00
levm_ERC20Mint 319.4 ± 5.1 315.0 332.3 2.23 ± 0.04

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.049 ± 0.015 1.036 1.084 1.00
levm_ERC20Approval 1.873 ± 0.014 1.854 1.910 1.79 ± 0.03

@github-actions

github-actions Bot commented May 22, 2025

Copy link
Copy Markdown

EF Tests Comparison

Test Name MAIN PR DIFF
Summary: 22201/22201 (100.00%) 22179/22201 (99.90%) ⬇️️ -22
Prague: 6617/6617 (100.00%) 6595/6617 (99.67%) ⬇️️ -22
Cancun: 8238/8238 (100.00%) 8238/8238 (100.00%) ➖️
Shanghai: 3841/3841 (100.00%) 3841/3841 (100.00%) ➖️
Paris: 3505/3505 (100.00%) 3505/3505 (100.00%) ➖️

@JereSalo JereSalo changed the title fix(levm): fix eip 7702 mistake when setting code fix(levm): trying out things with eip 7702 May 22, 2025
@JereSalo

JereSalo commented May 22, 2025

Copy link
Copy Markdown
Contributor Author

Closing because my theory was wrong :)

@JereSalo JereSalo closed this May 22, 2025
@edg-l edg-l mentioned this pull request Jun 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JereSalo JereSalo

Labels

levm Lambda EVM implementation

Projects

ethrex_l1
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JereSalo