Conversation
Collaborator
|
This is awesome! |
mpaulucci
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Being able to run hive rpc-compact test suite in the CI
Description
hiveworkflow that runs all currently passing rpc-compact hive tests to ensure there are no regressionsAs more tests pass, the
HIVE_TEST_PATTERNenv var can be updated to include more test cases and eventually be removed when all of them passConsiderations
As we are only running a subset of the whole hive testing framework we can run them in each PR, if this ends up taking too long we can move it to a daily job instead
At the time of making this pr only the eth_chainId, eth_getTransactionByBlockHashAndIndex & eth_getTransactionByBlockNumberAndIndex tests are passing, more should be added with future fixes
Closes None