Skip to content

fix: output format for eth_getStorageAt rpc endpoint#260

Merged
fmoletta merged 2 commits into
mainfrom
fix-storage-rpc
Aug 16, 2024
Merged

fix: output format for eth_getStorageAt rpc endpoint#260
fmoletta merged 2 commits into
mainfrom
fix-storage-rpc

Conversation

@fmoletta

Copy link
Copy Markdown
Contributor

Motivation
We are getting failures in hive tests due to the formatting of the storage values in etc_getStorageAt ie:

[16a390f6] <<  {"id":1,"jsonrpc":"2.0","result":"0x1c"}
[16a390f6] response differs from expected (-- client, ++ test):
[16a390f6]  {
[16a390f6]    "id": 1,
[16a390f6]    "jsonrpc": "2.0",
[16a390f6] -  "result": "0x1c"
[16a390f6] +  "result": "0x000000000000000000000000000000000000000000000000000000000000001c"
[16a390f6]  }

Description

  • Convert storage values from U256 to H256 before serializing them to ensure the correct format is shown in rpc endpoint eth_getStorageAt

Closes None, but fixes formatting issues in hive tests for eth_getStorageAt

@fmoletta fmoletta marked this pull request as ready for review August 15, 2024 15:04
@fmoletta fmoletta requested a review from a team as a code owner August 15, 2024 15:04
@fmoletta fmoletta added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 3f390af Aug 16, 2024
@fmoletta fmoletta deleted the fix-storage-rpc branch August 16, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants