fix: eth_getBalance, eth_getCode & eth_getStorageAt: return default value if account is not found#259
Merged
Merged
Conversation
eth_getBalance: return zero if account is not foundeth_getBalance, eth_getCode & eth_getStorageAt: return default value if account is not found
This was referenced Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rpc endpoint
eth_getBalanceshould return 0 if the account is not present in the storage.Rpc endpoint
eth_getCodeshould return empty bytes if the account is not present in the storage.Rpc endpoint
eth_getStorageAtshould return 0 if the account or storage slot is not present in the storage.Description
eth_getBalance: return zero if the account is not part of the stateeth_getCode: return empty bytes if the account is not part of the stateeth_getStorageAt: return zero if the account or storage slot is not part of the stateCloses None, but makes hive test
eth_getBalance/get-balance-unknown-accountð_getCode/get-code-unknown-accountpass. (eth_getStorageAt/get-storage-unknown-accountwould also pass if it weren't for formatting differences)