fix: update latest block number when adding a block#255
Merged
Conversation
This was referenced Aug 15, 2024
ElFantasma
approved these changes
Aug 16, 2024
mpaulucci
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When we add a block to this store this block will always become the latest block.
Previously we handled this by updating the latest block number after we added a new block but this was not consistent as we had to remember to update the last block number after each call to add block, leading to bugs.
This PR aims to solve this issue by including the update of the latest block number in the store's add block functionality.
Description
update_latest_block_numberinStore::add_blockupdate_latest_block_numberelsewhereCloses Closes #266