feat: compare world state root against block state root before storing block + fix libmdx impl#250
Merged
Merged
Conversation
…are-state-root-execute-block
Collaborator
|
LGTM. One thing that is missing to close the ticket is that we want to validate that the incoming payload is the direct child of the head block. If it's not we should fail/panic since we don't support reorgs yet |
Contributor
Author
Good catch!, I'll make a PR for it |
mpaulucci
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Validating the world state root against the state root in the block after executing payloads
Description
Closes None, but is part of #100