feat: process withdrawals + fix block decoding in ef tests#213
Merged
Conversation
…cess-withdrawals
…cess-withdrawals
e2e2b16 to
646b3c7
Compare
mpaulucci
reviewed
Aug 1, 2024
| pub withdrawals: Option<Vec<Withdrawal>>, | ||
| } | ||
|
|
||
| impl BlockWithRLP { |
mpaulucci
reviewed
Aug 1, 2024
| } | ||
|
|
||
| /// Increments the balance of an account by a given ammount (if it exists) | ||
| fn increment_balance(&mut self, address: Address, amount: U256) -> Result<(), StoreError> { |
Collaborator
There was a problem hiding this comment.
I worry a bit that this is a separate step from the other updates to accounts. I think eventually we will want to have some kind of "changeset" tables so that we can go back in case of a chain reorg, and that will be more challenging the less "atomic" the changes are. But I think we're fine though, I don't have a concrete suggestion
mpaulucci
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adding the ability to process withdrawals after performing sate transitions
Description
process_withdrawalseip4895_withdrawalstests to the ef tests shangai test harnessCloses #22