feat: add rpc endpoint eth_getCode#162
Merged
Merged
Conversation
…-block-number-table
…-block-number-table
…_block_by_number
…_block_by_number
mpaulucci
reviewed
Jul 18, 2024
| Ok(self.block_numbers.get(&block_hash).copied()) | ||
| } | ||
|
|
||
| fn add_account_code(&mut self, code_hash: H256, code: Bytes) -> Result<(), StoreError> { |
Collaborator
There was a problem hiding this comment.
question: why don't we have to specify pub here?
Contributor
Author
There was a problem hiding this comment.
It is part of a trait implementation, so it has the same visibility as the trait (which is public in this case)
mpaulucci
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #160
Motivation
Support rpc endpoint
eth_getCodeDescription
eth_getCodeStoreapiCloses #38