refactor: use map_requests for handle_http_requests#156
Merged
Conversation
map_requests for handle_http_requestsmap_requests for handle_http_requests
map_requests for handle_http_requestsmap_requests for handle_http_requests
This was referenced Jul 17, 2024
Collaborator
|
👍 with the idea, I would add |
mpaulucci
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
handle_http_requestsdoesn't allow us to return an error when handling requests. This can be solved by handling them via amap_requestsfunction like inhandle_authrpc_requests. Whilehandle_authrpc_requestshandles comunication between clients andhandle_http_requestshandles comunication between the client and users, there are a lot of requests that are handled by both of them. As they both use the same request format, there is little reason to implement two different functions to handle the same requests in the same way. We can usemap_requeststo handle both auth_rpc and http requests, and then implement a second handler (such asmap_internal_requests) to handle auth_prc-specific requests.Description
Replaces
handle_http_requestsrequest handling with a call tomap_requestsCloses None, but addresses comment on #145