feat: implement rlpx handshake#102
Merged
Merged
Conversation
ElFantasma
reviewed
Jul 12, 2024
| }; | ||
| use tokio::io::AsyncReadExt; | ||
| use tokio::{ | ||
| io::AsyncWriteExt, |
Contributor
There was a problem hiding this comment.
AsyncReadExt and AsyncWriteExt could be declared in the same use line.
cargo fmt does not fit these together? 🤔
Collaborator
There was a problem hiding this comment.
cargo fmt doesn't merge them by default, so I did it manually. We might want to modify the imports_granularity setting for this.
ElFantasma
reviewed
Jul 12, 2024
| auth.encode(&mut encoded_auth_msg); | ||
| encoded_auth_msg.resize(encoded_auth_msg.len() + padding_length, 0); | ||
|
|
||
| let ecies_data_size = 65 + 16 + 32; |
Contributor
There was a problem hiding this comment.
shouldn't we comment the reason behind these numbers?
ElFantasma
reviewed
Jul 12, 2024
| self.handshake_data.is_some() | ||
| } | ||
|
|
||
| pub fn encode_auth_message( |
Contributor
There was a problem hiding this comment.
Maybe this function could benefit from some inline comments
ElFantasma
reviewed
Jul 12, 2024
| H520(signature_bytes) | ||
| } | ||
|
|
||
| pub fn decode_ack_message(&mut self, static_key: &SecretKey, msg: &mut [u8]) { |
Contributor
There was a problem hiding this comment.
This function could have inline comments, as well.
ElFantasma
approved these changes
Jul 12, 2024
ElFantasma
left a comment
Contributor
There was a problem hiding this comment.
Other than (optional) minor comments, it LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes #125