Skip to content

Review if eth_getBlockByNumber should return non-canonial blocks #589

@mpaulucci

Description

@mpaulucci

See this discussion: https://github.com/lambdaclass/ethereum_rust/pull/571/files#r1778873779

It seems we should not return blocks that haven't been set as canonical, but some hive tests seem to rely on it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    L1Ethereum clientconsensusReorgs, Fork Choice, etc

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions