In #2658 we wanted to validate block bodies against headers during syncing to fail early and discard peers sending us incorrect blocks. For this a new function validate_block_bodies was created. This function was also add to the validate_block function but it proved to degrade performance as checked here.
We'll remove it from the time being given that it wasn't the objective of the initial PR related to validate block bodies to add that check at that level. Also everything was working as expected before it. But we might want to check this are not needed validations, or in case they are, re add them focusing on performance.
In #2658 we wanted to validate block bodies against headers during syncing to fail early and discard peers sending us incorrect blocks. For this a new function
validate_block_bodieswas created. This function was also add to thevalidate_blockfunction but it proved to degrade performance as checked here.We'll remove it from the time being given that it wasn't the objective of the initial PR related to validate block bodies to add that check at that level. Also everything was working as expected before it. But we might want to check this are not needed validations, or in case they are, re add them focusing on performance.