Conversation
f908e83 to
b65c5cc
Compare
This commit refactors the Docker task naming convention for clarity and consistency. - Renames "publish" tasks to "push" (e.g., `dockerPublish` is now `dockerPush`). - Introduces a `dockerPrepare` task group. - `dockerBuild` tasks now depend on `dockerPrepare`. - `dockerPush` tasks now depend on `dockerBuild`. - `dockerBuildxPush` tasks now depend on `dockerPrepare`. - Defaults `imageVersion` to `project.version`. - Updates task arguments to use the new naming and reflect these dependency changes. - Ensures "latest" tags are pushed correctly when `isLatestTag` is true.
b65c5cc to
6e692db
Compare
…p.shadow-distributions
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Docker plugin's task naming convention from "publish" to "push" terminology and introduces better task dependency management. The changes align the plugin's terminology with Docker's standard CLI commands while improving task organization.
- Renames all "publish" related tasks to "push" (e.g.,
dockerPublish→dockerPush) - Introduces a new
dockerPreparetask group with proper dependency chains - Updates default
imageVersionto useproject.versionautomatically
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| DockerPlugin.kt | Core refactoring of task names from "publish" to "push", added dockerPrepare task group, and updated task dependencies |
| DockerImage.kt | Added default convention for imageVersion to use project.version |
| README.md | Updated documentation to reflect "push" terminology throughout |
| verify.yml | Minor workflow name updates and added --info flag for debugging |
plugin/src/main/kotlin/io/github/lamba92/gradle/docker/DockerPlugin.kt
Outdated
Show resolved
Hide resolved
plugin/src/main/kotlin/io/github/lamba92/gradle/docker/DockerPlugin.kt
Outdated
Show resolved
Hide resolved
plugin/src/main/kotlin/io/github/lamba92/gradle/docker/DockerPlugin.kt
Outdated
Show resolved
Hide resolved
…p.shadow-distributions
…flow - Introduced a `verifyDockerRun` task to validate Docker container output matches expected results. - Updated the CI workflow to include the `verifyDockerRun` task in the verification process. - Adjusted `dockerRun` task group from "docker" to "application" for better task segregation.
…om.gradleup.shadow-distributions' into lamberto.basti/#37-Support-for-com.gradleup.shadow-distributions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the Docker task naming convention for clarity and consistency.
dockerPublishis nowdockerPush).dockerPreparetask group.dockerBuildtasks now depend ondockerPrepare.dockerPushtasks now depend ondockerBuild.dockerBuildxPushtasks now depend ondockerPrepare.imageVersiontoproject.version.isLatestTagis true.