Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Gradle wrapper to version 8.14.3 by bumping the distribution in properties and aligning both Windows and Unix start scripts.
- Added SPDX license headers and standardized error redirection in scripts.
- Changed how wrapper JAR is invoked (using
-jar) and cleaned up CLASSPATH handling. - Updated
gradle-wrapper.propertieswith the new distribution URL,networkTimeout, andvalidateDistributionUrl.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gradlew.bat | Added SPDX header, redirected error output to stderr, switched to -jar invocation, and reset CLASSPATH variable |
| gradlew | Added SPDX header, improved APP_HOME resolution, added xargs check, refactored argument collection, cleared CLASSPATH |
| gradle/wrapper/gradle-wrapper.properties | Bumped Gradle distribution to 8.14.3; added networkTimeout and validateDistributionUrl |
| set DIRNAME=%~dp0 | ||
| if "%DIRNAME%" == "" set DIRNAME=. | ||
| if "%DIRNAME%"=="" set DIRNAME=. | ||
| @rem This is normally unused |
There was a problem hiding this comment.
[nitpick] The comment 'This is normally unused' on APP_BASE_NAME may be confusing, since APP_BASE_NAME is actually used when constructing the -Dorg.gradle.appname argument. Consider clarifying or removing this remark to avoid misleading future maintainers.
| @rem This is normally unused | |
| @rem Used to construct the -Dorg.gradle.appname argument for Gradle execution |
| esac | ||
|
|
||
| CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar | ||
| CLASSPATH="\\\"\\\"" |
There was a problem hiding this comment.
Setting CLASSPATH to literal escaped quotes will cause Java to interpret the classpath as "" rather than empty. Replace this with a simple empty assignment, e.g., CLASSPATH="", or unset it entirely before invoking the JAR.
| CLASSPATH="\\\"\\\"" | |
| CLASSPATH="" |
No description provided.