Skip to content

Refactor project structure and improve Docker plugin#14

Merged
lamba92 merged 1 commit intomasterfrom
restructure-plugin
Jan 13, 2025
Merged

Refactor project structure and improve Docker plugin#14
lamba92 merged 1 commit intomasterfrom
restructure-plugin

Conversation

@lamba92
Copy link
Copy Markdown
Owner

@lamba92 lamba92 commented Jan 13, 2025

No description provided.

Copilot AI review requested due to automatic review settings January 13, 2025 11:32
@lamba92 lamba92 self-assigned this Jan 13, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 21 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • example/build.gradle.kts: Language not supported
  • local.properties: Language not supported
  • plugin/gradle.properties: Language not supported
  • plugin/settings.gradle.kts: Language not supported
  • plugin/src/main/kotlin/io/github/lamba92/gradle/docker/CreateJvmDockerfile.kt: Language not supported
  • plugin/src/main/kotlin/io/github/lamba92/gradle/docker/DockerExtension.kt: Language not supported
  • plugin/src/main/kotlin/io/github/lamba92/gradle/docker/DockerImage.kt: Language not supported
  • plugin/src/main/kotlin/io/github/lamba92/gradle/docker/DockerImageContainer.kt: Language not supported
  • plugin/src/main/kotlin/io/github/lamba92/gradle/docker/DockerPlugin.kt: Language not supported
  • plugin/src/main/kotlin/io/github/lamba92/gradle/docker/DockerUtils.kt: Language not supported
  • settings.gradle.kts: Language not supported
  • src/main/kotlin/io/github/lamba92/gradle/docker/DockerExtension.kt: Language not supported
  • src/test/kotlin/io/github/lamba92/gradle/docker/tests/DockerBuildxTests.kt: Language not supported
  • src/test/kotlin/io/github/lamba92/gradle/docker/tests/DockerPluginTests.kt: Language not supported
  • src/test/kotlin/io/github/lamba92/gradle/docker/tests/DockerTests.kt: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/verify.yml:25

  • [nitpick] Running ktlintCheck twice might be redundant. Please clarify if both checks are necessary.
./gradlew --no-build-cache ktlintCheck :plugin:ktlintCheck

.github/workflows/verify.yml:46

  • The removal of the upload-artifact step for test results might cause issues if those artifacts are needed for later stages or debugging. Please ensure this change is intentional.
./gradlew :example:dockerPublish :example:dockerBuildxPublish

@lamba92 lamba92 force-pushed the restructure-plugin branch from a854fde to 9823f0d Compare January 13, 2025 11:39
Reorganized the project structure by separating the plugin implementation into its own module and renaming directories/files for clarity. Enhanced Docker plugin functionality with configurable JVM application support. Updated build scripts and CI workflows to reflect the changes.
@lamba92 lamba92 force-pushed the restructure-plugin branch from 9823f0d to 69505a9 Compare January 13, 2025 11:41
@lamba92 lamba92 merged commit 93fbe0a into master Jan 13, 2025
@lamba92 lamba92 deleted the restructure-plugin branch January 13, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants