python: Include line number in state error#340
Merged
geonnave merged 1 commit intolake-rs:mainfrom Feb 3, 2025
Merged
Conversation
StateMismatch errors can be quite hard to understand, this gives at least a pointer to where it comes from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StateMismatch errors can be quite hard to understand, this gives at least a pointer to where it comes from.
This is certainly not ideal: Ideally we'd describe in understandable terms on every location where a StateMismatch is created why that is, and/or have the Rust location as part of the Python object cause chain. The comment explains why we can't have the latter easily, and a longstanding comment on StateMismatch explains why the former is not easy.
Adding those line numbers is helpful to some, and currently the best we can do with the resources we have.