Merged
Conversation
Collaborator
|
Thanks, just went through (including latest commit for larger KIDs) and is looking good. Happy to merge once CI is green. |
Member
Author
|
That latest commit was pushed by accident and is now in #326. CI gets upset because apparently the doc comments get translated to C (cbindgen?), and there the compiler is not super happy about comments-in-comments (no way!); I'll look briefly into whether cbindgen can be made to play ball, but chances are I'll just remove those comments. |
Member
Author
|
The bindgen issue seems to be previously unnoticed; I'm adding a workaround. |
Member
Author
|
I think this is ready now; fixing things on cbindgen would have been excessive, so the comments in the doctest are in a less-than-ideal position as a workaround. |
Collaborator
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small fixes I found when updating Ariel OS to use the latest lakers:
[edit] Note that the way it is used internally (eg. decode_plaintext_3), the length is pre-checked to be correct due to
decoder.any_as_encoded(), but that also means we're doing double work – still, a public function should do proper error handling.