Merged
Conversation
Previously, a call to `.edhoc_exporter()` would happily have produced exports from the all-zero key material.
geonnave
approved these changes
Nov 5, 2024
Collaborator
geonnave
left a comment
There was a problem hiding this comment.
Went through and it looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a call to
.edhoc_exporter()would happily have produced exports from the all-zero key material.This would have prevented the hiccup I ran into around #312 (comment).
The present change ensures that attempting to run the EDHOC exporter results in a runtime error. aiocoap's tests still pass with it.
I'd prefer to go further, making the initiator start item also an option, or making this all into an enum, or even just using the high-level API, but this way at least we avoid inadvertently poking into data that should already be gone (which is something the high-level API would also ensure we don't do). Also I think that almost none of those items should implement Default. But let's do this here first and take it incrementally.
CC'ing @ElsaLopez133 (why can't I ask you to be a reviewer?) for review and because this might cause subtle (but easy to resolve) breakage with PR #312