Merged
Conversation
The previously used vector was valid but merely unsupported.
This used the wrong encoding function, which made no difference before when only short C_x were supported.
This made no difference as long as all C_x were numeric and had identical slice and CBOR representations.
Member
Author
|
I had to add one more fix where we used Please review. |
geonnave
reviewed
Nov 5, 2024
Collaborator
|
Thanks for this PR! I went through and actually have no extra comments. Merging. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #258
This is a straightforward change and relatively complete; noteworthy points are:
Grep for
from_int_rawto see all possible places; in particular, I known of the C API, and of the automatic generation of identifiers.