Fix the compilation target of the lakers_nrf52840 example to Cortex-M4F using hard floats#314
Merged
geonnave merged 1 commit intolake-rs:mainfrom Oct 28, 2024
Conversation
This fixes the issue of mismatched binary of Cryptocell310 and the nRF compilation target, making cryptocell310-based backend work in this example, as well. Using now the cryptocell310 backend by default.
geonnave
approved these changes
Oct 28, 2024
Collaborator
geonnave
left a comment
There was a problem hiding this comment.
Excellent, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue of mismatched binary of Cryptocell310 and the nRF compilation target, making cryptocell310-based backend work in this example, as well. Using now the cryptocell310 backend by default.
Fixes #313