Merged
Conversation
2834fa2 to
e9944be
Compare
Member
Author
|
I think this is ready for review; it passes CI. Changes apart from "fixing the issue" are:
After this got merged, please consider adding the "build python wheels" check(s) to the mandatory list for merging. |
Collaborator
Member
Author
|
There's no hurry with that: having those builds visible and non-blocking would still be an improvement. |
geonnave
reviewed
Jun 23, 2024
This ensures that they are useable for a full build.
This is the only regular testing we get on exotic platforms (Windows, MacOS), and it helps spot changes in the manifest Cargo.toml that only manifest during Python builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #289