coapserver-coaphandler: Restore feature parity with coapserver#239
Merged
geonnave merged 3 commits intolake-rs:mainfrom Mar 8, 2024
Merged
Conversation
While the coap crate does tolerate such requests to a not-wrong-but-different-and-clearly-unintended resource, the coaphandler based implementation is stricter.
Collaborator
|
Looks good, thanks for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
authz support was added to the coapserver but not to coapserver-coaphandler; this fixes the regression.
This is based on #238 because the C client's bugs were hidden by coapserver's lax handling (see martindisch/coap-lite#36), and would otherwise make it unusable for even basic testing.